Increase robustness of ProcessManager.terminate() in the face of zombies.

Review Request #2513 - Created July 22, 2015 and submitted

Information
Kris Wilson
pants
kwlzn/processmgr_zombie
7e31ed8...
Reviewers
pants-reviews
areitz, benjyw, jsirois, nhoward_tw, stuhood, zundel
- Implement zombie detection in ProcessManager.is_alive()
- Implement stale pid detection in ProcessManager.is_alive() and enforce for NailgunExecutor
- Misc refactoring + improved usage of psutil.Process attributes in support of the above
- Tests

https://github.com/pantsbuild/pants/pull/1848 + setup a centos6 vm, created a zombie process via a test harness and attempted to kill it via the ng-killall code path (which relies on ProcessManager.terminate() & is_alive()). verified this change successfully prevents the exception case on linux when trying to kill a zombie'd process.

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Andy Reitz
Kris Wilson
Eric Ayers
John Sirois
John Sirois
Eric Ayers
Nick Howard (Twitter)
Kris Wilson
John Sirois
Nick Howard (Twitter)
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as eca2c7192ef13b239bd2e387cb5759c5acf9e558

Loading...