Add a synthetic product dep to thrift compilers

Review Request #2512 — Created July 22, 2015 and updated

stuhood
pants
3e13504...
pants-reviews
areitz, davidt, jsirois, patricklaw

Add a synthetic product dep to thrift compilers to allow tasks in plugins to run before thrift compilation.

https://github.com/pantsbuild/pants/pull/1850

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
where is 'thrift_inputs' returned as products_types(..)? IT ity
JS
  1. You should probably add David Taylor and have a look at these:
    https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/core/tasks/noop.py
    https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/core/tasks/changed_target_goals.py#L17
  2. 
      
ST
Review request changed

Change Summary:

+davidt


@John: I don't think our usecase is related... we have a task that is generating thrift code, and rather than hacking things by installing it at the head of the gen goal, I was hoping to do things slightly more correctly.

People:

+davidt
ST
  1. ping

  2. 
      
IT
  1. 
      
  2. where is 'thrift_inputs' returned as products_types(..)?

    1. Ok, I think I understand John's comment now: thanks. Since nothing is providing these products, they'll fail fast. So we either need a noop task to provide them, or we need to provide them from some other built in task.

  3. 
      
Loading...