1762 - Remove old cache files

Review Request #2506 - Created July 21, 2015 and submitted

Information
Matt Olsen
pants
https://github.com/pantsbuild/pants/issues/1762
3ff498f...
Reviewers
pants-reviews

remove old cache files that exceed --cache-max-old

fix test issues with temp cache

Fix defaults to properly preserve old behavior

add tests for cache cleanup

For additional context: https://rbcommons.com/s/twitter/r/2477/

https://github.com/pantsbuild/pants/pull/1843

./pants test tests/python/pants_test/backend/core/tasks:cache_cleanup

Also manual testing such as:
rm -rf .buildcache/*; ./pants clean-all; mkdir -p .buildcache/abc_Checkstyle_compile_checkstyle/src.java.org.pantsbuild.args4j.args4j/; touch .buildcache/abc_Checkstyle_compile_checkstyle/src.java.org.pantsbuild.args4j.args4j/test.txt; sleep 1; touch .buildcache/abc_Checkstyle_compile_checkstyle/src.java.org.pantsbuild.args4j.args4j/test1.txt; sleep 1; touch .buildcache/abc_Checkstyle_compile_checkstyle/src.java.org.pantsbuild.args4j.args4j/test2.txt; ./pants compile src/java/org/pantsbuild/tools/junit/

Issues

  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Matt Olsen
Matt Olsen
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Stu Hood
Matt Olsen
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 9e801408551beed380c8427013875da6a39d6a89

Thanks!

Loading...