Disambiguate distributions installed in generic site-packages path during pex_bootstrap.

Review Request #249 — Created April 18, 2014 and submitted

wickman
commons
pants-reviews
jsirois
Disambiguate distributions installed in generic site-packages path during pex_bootstrap.

If you pip install twitter.common.python using sufficiently new pips, it will get installed into site-packages as an EGG-INFO distribution instead of an .egg.  This means its dist.location is site-packages instead of site-packages/setuptools.egg, so interpreter.get_location('setuptools') is ambiguous.  This removes the ambiguity by adding a name= keyword to DistributionHelper.distribution_from_path.
./pants py src/python/twitter/pants -- build -i CPython==3.4.0 tests/python/twitter/common/python:all -v
./pants py src/python/twitter/pants -- build -i CPython==2.7.6 tests/python/twitter/common/python:all -v
./pants py src/python/twitter/pants -- build -i CPython==2.6.9 tests/python/twitter/common/python:all -v
WI
JS
  1. Ship It!
  2. 
      
WI
  1. Has anyone been seeing these errors?
    
    mba=commons=; ./rbt patch -c 249
    Patch is being applied from request 249 with diff revision  1.
    CRITICAL:root:Object does not exist (HTTP 404, API Error 100)
    
    I have been unable to run rbt patch for a while.
  2. 
      
WI
Review request changed

Status: Closed (submitted)

Loading...