Re-compute the classpath for each batch of junit tests.

Review Request #2454 - Created July 10, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/per-test-classpath
1787
0bb5b72...
Reviewers
pants-reviews
jsirois, stuhood, zundel

This handles the case where tests define duplicate resources,
which is a common use-case for Square.

Also changed the default working directory for tests to be the build
root, instead of being the (very arbitrary) spec_path of the first
target in the set of test targets.

This may break some folks tests if they had missing dependencies that were getting pulled in by chance by other targets, or if they relied on the default working directory being the spec_path of the first target.

Specifying --test-junit-cwd without setting a value for it is no longer allowed, as it would be identical behavior to just not specifying the flag at all.

Added maven/style testproject and associated integration tests.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/70401025

CI went green (again) here: https://travis-ci.org/pantsbuild/pants/builds/70425948

CI went green (again (again)) here: https://travis-ci.org/pantsbuild/pants/builds/70781015

Issues

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Eric Ayers
Garrett Malmquist
Nick Howard (Twitter)
Garrett Malmquist
Garrett Malmquist
John Sirois
Garrett Malmquist
John Sirois
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

Committed in 49706af85be0e532e89c1b3dbd6e88e3634a8bf1.

Loading...