Record all output classes for the jvm isolated compile strategy

Review Request #2451 - Created July 9, 2015 and submitted

Information
Stu Hood
pants
703c5a6...
Reviewers
pants-reviews
benjyw, fkorotkov, jsirois, nhoward_tw, tejal, zundel

This change causes the isolated strategy to fully record classpath entries for jvm targets, meaning that the content generated by bundle should fully match the classpath during test.junit. This partially addresses an issue we saw internally with untracked classes (likely a zinc bug), and allows for extra outputs generated by tools like autovalue to be included.

  • Record all output classes (files) for the isolated strategy.
  • Log a debug entry when classes were unclaimed by analysis.

https://github.com/pantsbuild/pants/pull/1785

John Sirois
John Sirois
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 709597d36240d32d9047afe8d0b257518294c1ae

Eric Ayers

   

I think this is going to help us a lot.

I am still concerned that this may pick up stale output from previous builds. (say if someone removes an @AutoValue annotation and recompiles.

  1. Totally... might want to go ahead and open a ticket for that one now =/

  2. Filed https://github.com/pantsbuild/pants/issues/1801 with a repro case

Loading...