Deprecate with_description.

Review Request #2444 - Created July 8, 2015 and submitted

Information
John Sirois
pants
jsirois/with_description/deprecate
1777
778d93c...
Reviewers
pants-reviews
gmalmquist, patricklaw
Fixup one with_description usage in the repo.

 src/python/pants/base/target_addressable.py | 12 ++++++++----
 zinc/BUILD                                  |  5 +++--
 2 files changed, 11 insertions(+), 6 deletions(-)

After deprecation:

$ ./pants list --documented 1>/dev/null
INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants3 on branch jsirois/python_test_suite/deprecate
WARN] While parsing FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants3/zinc/BUILD):
    5:   dependencies=[
    6:     'src/scala/org/pantsbuild/zinc',
    7:   ]
*   8: ).with_description("zinc -- the scala compiler in nailgun")
        DeprecationWarning: 
pants.base.target_addressable.with_description is deprecated and will be removed in version 0.0.38:
Use the target description keyword argument instead of the deprecated with_description target method.

    9: 
...

After fix:

$ ./pants list --documented zinc/
INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants3 on branch jsirois/python_test_suite/deprecate
zinc:zinc
  zinc -- the scala compiler in nailgun

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/70139175

John Sirois
John Sirois
Garrett Malmquist
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...