[core][GroupTask] Faster coalesce_targets

Review Request #2413 - Created June 24, 2015 and submitted

Information
Sergey Serebryakov
pants
sserebryakov/core/coalesce
1733
807596a...
Reviewers
pants-reviews
jsirois, kwlzn, patricklaw

Using linear-time BFS to sort targets topologically and group them by the type, instead of quadratic-time greedy rearrangement algorithm.

Also
- splitting sort_targets into invert_dependencies+sort_targets.
- changing a test to check for both correct answers

./pants test tests/python/pants_test/tasks:group_task

Green CI: https://travis-ci.org/pantsbuild/pants/builds/69215674

I used this command for benchmarking:

./pants compile src/scala/com/twitter/ads/batch/job/targeting/audience_extension/profile:audience-extension-profile-deploy --config-override=pants.ini.nocache

Issues

  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Stu Hood
Sergey Serebryakov
Stu Hood
Kris Wilson
Patrick Lawson
Sergey Serebryakov
Sergey Serebryakov
Sergey Serebryakov
Sergey Serebryakov
Stu Hood
Sergey Serebryakov
Sergey Serebryakov
Review request changed

Status: Closed (submitted)

Change Summary:

(re)merged as 63cc6f44cf3824385f0d69e2a2570d8340fdc297

Thanks Sergey!

Loading...