Fix bad logger.debug call in artifact_cache.py

Review Request #2386 - Created June 17, 2015 and submitted

Information
Stu Hood
pants
73425d8...
Reviewers
pants-reviews
davidt, jsirois, kwlzn, nhoward_tw, zundel
  • Fix a debug-level call in artifact_cache.py that explodes when pants is run at -ldebug

Sidenote, there are a lot of calls that use string formatting rather than any type of logger-supported interpolation that would be skipped when a particular log level is disabled. I suspect that this has a very significant performance cost.

  File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 859, in emit
    msg = self.format(record)
  File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 732, in format
    return fmt.format(record)
  File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 471, in format
    record.message = record.getMessage()
  File "/Users/stuhood/Python/CPython-2.7.8/lib/python2.7/logging/__init__.py", line 335, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Logged from file artifact_cache.py, line 82

  
John Sirois
David Taylor
Stu Hood
Review request changed

Status: Closed (submitted)

Loading...