Scrub timestamp from antlr generated files to have stable fp for cache

Review Request #2382 - Created June 17, 2015 and submitted

Information
Qicheng Ma
pants
1701
bcd7a26...
Reviewers
pants-reviews
areitz, fkorotkov, jsirois, stuhood

Add integration test and fix unit test

Removes only first line

Remove line used for debugging.

Running CI: https://travis-ci.org/pantsbuild/pants/builds/67450219

Local Testing:

(in master)
$ PANTS_DEV=1 ./pants clean-all compile ./examples/src/antlr/org/pantsbuild/example/exp::
$ head /Users/qma/workspace/pants/.pants.d/gen/antlr/antlr3/gen-java/examples/src/antlr/org/pantsbuild/example/exp/ExpAntlr3Lexer.java
// $ANTLR 3.4 examples/src/antlr/org/pantsbuild/example/exp/ExpAntlr3.g 2015-06-16 15:45:46

  package org.pantsbuild.example.exp;


import org.antlr.runtime.*;
import java.util.Stack;
import java.util.List;
import java.util.ArrayList;

(in this branch)
$ PANTS_DEV=1 ./pants clean-all compile ./examples/src/antlr/org/pantsbuild/example/exp::
$ head /Users/qma/workspace/pants/.pants.d/gen/antlr/antlr3/gen-java/examples/src/antlr/org/pantsbuild/example/exp/ExpAntlr3Lexer.java

  package org.pantsbuild.example.exp;


import org.antlr.runtime.*;
import java.util.Stack;
import java.util.List;
import java.util.ArrayList;

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Qicheng Ma
John Sirois
Qicheng Ma
Qicheng Ma
Qicheng Ma
Qicheng Ma
Stu Hood
Qicheng Ma
Qicheng Ma
Qicheng Ma
Qicheng Ma
Stu Hood
Qicheng Ma
John Sirois
Qicheng Ma
John Sirois
Qicheng Ma
Qicheng Ma
Stu Hood
John Sirois
John Sirois
Qicheng Ma
Qicheng Ma
Qicheng Ma
Review request changed

Status: Closed (submitted)

Loading...