Fixup the Git Scm detection of server_url.

Review Request #2379 - Created June 17, 2015 and submitted

Information
John Sirois
pants
jsirois/git/fix_server_url
1444, 1699
1c845e5...
Reviewers
pants-reviews
areitz, dturner-tw
Previously any remote with origin in its name would suffice, leading to
a failure to detect remotes actually named 'origin' or else
mis-identifying an un-intended server_url.

 src/python/pants/scm/git.py             | 16 +++++++++++-----
 tests/python/pants_test/scm/test_git.py |  7 ++++---
 2 files changed, 15 insertions(+), 8 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/67116155

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
David Turner
Andy Reitz
John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...