Ensure caliper is shaded in bench, add bench desc, use RUN so that output is printed

Review Request #2353 - Created June 12, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1674
5194a39...
Reviewers
pants-reviews
benjyw, fkorotkov, ity, jsirois, stuhood, tejal, zundel

caliper depends on guava 11 which is incompatible with guavas above 15 due to deprecated method removals, adding main to the jvm tool registration causes it to be shaded, which means the older guava won't interfer with code under test that depends on newer guava versions.

I also added a description and set the WorkUnit.RUN label so that the caliper output will be printed to the console by default.

tested against a target with a dependency on guava 16, which failed to run without shading. CI in PR

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Stu Hood
Nick Howard (Twitter)
Nick Howard (Twitter)
Stu Hood
Nick Howard (Twitter)
Nick Howard (Twitter)
John Sirois
Nick Howard (Twitter)
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Nick Howard (Twitter)

submitted at https://github.com/pantsbuild/pants/commit/cb0cc7a6517f996a162027dab17c083fa9990bf3

Loading...