Compute exclude_patterns first when unpacking jars

Review Request #2352 - Created June 12, 2015 and submitted

Information
Eric Ayers
pants
1671
fa3c6df...
Reviewers
pants-reviews
dturner-tw, jsirois, nhoward_tw
Compute exclude_patterns first when unpacking jars

CI is sort of green at https://travis-ci.org/pantsbuild/pants/builds/66536299

Found a problem in our repo with an unpack_jars() target and found two bugs.
1) If you don't evaluate excludes first, the excludes have no effect
2) * in a pattern doesn't match zero characters. See https://rbcommons.com/s/twitter/r/2351/

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Garrett Malmquist
John Sirois
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

686eabd

Loading...