Bugfix for fnmatch_translate_extended()

Review Request #2351 - Created June 12, 2015 and discarded

Information
Eric Ayers
commons
zundel/extended-translate-fnmatch
380, 381
Reviewers
pants-reviews
dturner-tw, jsirois

Bugfix for fnmatch_translate_extended to match '*' with 0 or more characters.

A pattern like foo*bar wouldn't match the string foobar before

CI is running https://travis-ci.org/twitter/commons/builds/66534681

Updated unit tests.

Issues

  • 1
  • 1
  • 0
  • 2
Description From Last Updated
Hmm. This adds another char to match at the end. I think that'll mean that a/a* won't match a/a. Is ... Nick Howard (Twitter) Nick Howard (Twitter)
John Sirois
David Turner
Eric Ayers
Eric Ayers
Eric Ayers
John Sirois
Eric Ayers
John Sirois
Eric Ayers
Nick Howard (Twitter)
Eric Ayers
Review request changed

Status: Discarded

Change Summary:

There is a forthcoming fix for the pants logic that depends on this in the globs handing from the new engine.

Loading...