Add INDEX.LIST to the filter list when bundling into a jar

Review Request #2342 - Created June 10, 2015 and submitted

Information
Eric Ayers
pants
zundel/filter-index-list-jar
1665
4da228a...
Reviewers
pants-reviews
dturner-tw, jsirois

Add INDEX.LIST to as a Skip JarRule when creating a fat jar

The INDEX.LIST files are usually created with jar i as some kind of optimizing step after a .jar file is built.

I found a problem when trying to add Class-Path: to a manifest file when building a fat jar. The root cause was an INDEX.LIST file from one of the dependent jars that got combined together. When this file is present, Class-Path: seems to be ignored.

The INDEX.LIST files are scrubbed out by default with the maven shade plugin:

https://github.com/intelie/maven-shade-plugin/blob/71b5895028f9c9ca2730b45d1117d8e6d3372a3e/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L137

John Sirois
Eric Ayers
John Sirois
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Commit 049321f

Loading...