Remove obsolete JarCreate constructor argument based tests.

Review Request #234 — Created April 16, 2014 and submitted

jsirois
pants
jsirois/jar_create/unbreak_tests
61
pants-reviews
tejal, travis
This should get us travis-ci green again.  We'll need to discuss how best to parameterize JarCreate to allow for ad-hoc skipping of javadoc jars when publishing locally.  That mechanism got thrashed a bit in review and is now broken - but this at least gets us green.


commit 20311362bd12245ad407652d193275fc0b7555f4
Author: John Sirois <jsirois@twitter.com>
Date:   Tue Apr 15 18:43:28 2014 -0700

    Remove obsolete JarCreate constructor argument based tests.
    
    The constructor argument exercised was removed.

 tests/python/pants_test/tasks/test_jar_create.py | 6 ------
 1 file changed, 6 deletions(-)
Before & in travis-ci:
...
    def assert_javadoc_jar_contents(self, context, empty=False, **kwargs):
      with self.add_products(context, 'javadoc', self.jl, 'a.html', 'b.html'):
        with self.add_products(context, 'scaladoc', self.sl, 'c.html'):
>         JarCreate(context, **kwargs).execute(context.targets())
E         TypeError: __init__() got an unexpected keyword argument 'jar_javadoc'

tests/python/pants_test/tasks/test_jar_create.py:228: TypeError


After:
$ ./pants tests/python/pants_test/tasks/:jar_create -v
Build operating on targets: OrderedSet([PythonTests(tests/python/pants_test/tasks/BUILD:jar_create)])
============================================================================================================================== test session starts ===============================================================================================================================
platform linux3 -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 -- /home/jsirois/dev/3rdparty/pyenv/versions/2.6.8/bin/python
plugins: cov
collected 10 items 

tests/python/pants_test/tasks/test_jar_create.py:64: JarCreateMiscTest.test_jar_create_init PASSED
tests/python/pants_test/tasks/test_jar_create.py:75: JarCreateMiscTest.test_resources_with_scala_java_files PASSED
tests/python/pants_test/tasks/test_jar_create.py:197: JarCreateExecuteTest.test_classfile_jar_flagged PASSED
tests/python/pants_test/tasks/test_jar_create.py:200: JarCreateExecuteTest.test_classfile_jar_not_required PASSED
tests/python/pants_test/tasks/test_jar_create.py:192: JarCreateExecuteTest.test_classfile_jar_required PASSED
tests/python/pants_test/tasks/test_jar_create.py:241: JarCreateExecuteTest.test_javadoc_jar_flagged PASSED
tests/python/pants_test/tasks/test_jar_create.py:236: JarCreateExecuteTest.test_javadoc_jar_required PASSED
tests/python/pants_test/tasks/test_jar_create.py:219: JarCreateExecuteTest.test_source_jar_flagged PASSED
tests/python/pants_test/tasks/test_jar_create.py:222: JarCreateExecuteTest.test_source_jar_not_required PASSED
tests/python/pants_test/tasks/test_jar_create.py:214: JarCreateExecuteTest.test_source_jar_required PASSED

=========================================================================================================================== 10 passed in 0.29 seconds ============================================================================================================================
TE
  1. Ship It!
  2. 
      
JS
  1. Thanks - merged
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...