Make sure arg to logRaw and log are only eval'ed once.

Review Request #2338 - Created June 9, 2015 and submitted

Information
Eric Ayers
pants
zundel/zinc-pass-byname
1655
49a927a...
Reviewers
pants-reviews
dturner-tw, stuhood

Stu pointed this out in https://rbcommons.com/s/twitter/r/2315/ after I submitted the PR.
The parameter message is passed by name, and so the argument might get evaluated in isFiltered() and in the logging function itself.
Also got rid of a deprecation warning for ConsoleLogger.stdout

Patched in locally.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Nick Howard (Twitter)
Eric Ayers
Stu Hood
Eric Ayers
John Sirois
Eric Ayers
John Sirois
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Nick, John & Stu: Commit 8b89654

Stu Hood
Ship It!
Loading...