Added a hash to a jar name for a bootstrapped jvm tool

Review Request #2334 - Created June 8, 2015 and submitted

Information
Fedor Korotkov
pants
1652
177c3aa...
Reviewers
pants-reviews
areitz, benjyw, ity, stuhood, tejal

Added a hash to a jar name for a bootstrapped jvm tool

Before fingerprints for scala and zinc for java tools were the same but the actual paths of shaded jars in artifacts were different. Removed scope and key from the jar_path and added a hash.

Example:

We compile a java target with Zinc and it will shade zinc and store it to an artifact. The artifact will contain only one jar file bootstrap/bootstrap-jvm-tools/tool_cache/shaded_jars/compile.zinc-java/zinc/org.pantsbuild.zinc.Main.jar.

Then we'll try to compile a Scala target and because the fingerprint is the same as for zinc-java it will use an artifact from zinc-java. But it will fail to locate a shaded jar at bootstrap-jvm-tools/tool_cache/shaded_jars/compile.zinc/zinc/org.pantsbuild.zinc.Main.jar and will shade it again.

https://travis-ci.org/fkorotkov/pants/builds/65968176

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andy Reitz
John Sirois
Fedor Korotkov
Fedor Korotkov
Andy Reitz
Tejal Desai
Fedor Korotkov
John Sirois
Fedor Korotkov
John Sirois
Benjy Weinberger
Fedor Korotkov
Fedor Korotkov
Benjy Weinberger
Fedor Korotkov
Review request changed

Status: Closed (submitted)

Loading...