Fix java zinc isolated compile analysis corruption

Review Request #2325 - Created June 4, 2015 and submitted

Information
Jessica Rosenfield
pants
jrosenfield/zinc-isolated-analysis_tmp
1626, 1639
2339
4e4a4de...
Reviewers
pants-reviews
jsirois, stuhood, zundel

Fix java zinc isolated compile analysis corruption described github issue #1626

Add use of temporary directories to create_compile_jobs
Add --delete-scratch to jvm_compile default options
Add ensure_analysis_tmpdir to jvm_compile_strategy to create the temporary analysis directory in both strategies

Travis CI in green build: https://travis-ci.org/pantsbuild/pants/builds/65623817

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
Jessica Rosenfield
Jessica Rosenfield
Jessica Rosenfield
Eric Ayers
John Sirois
Jessica Rosenfield
John Sirois
Jessica Rosenfield
John Sirois
Eric Ayers
Jessica Rosenfield
Jessica Rosenfield
Jessica Rosenfield
Jessica Rosenfield
Review request changed

Status: Closed (submitted)

Change Summary:

Committed as 92abf54. I'm learning a lot from the work I'm doing but not as much as I am from code reviews. Thank you John, Eric and Nick for your help!

Stu Hood

Thanks for the fix!

Hm... this was the intended goal of the _empty_analysis_cleanup decorator, so perhaps that code is no longer necessary?

  1. _empty_analysis_cleanup is intended to clean up a half-written or unparsable analysis file, so I agree, it might be unecessary if this was the only cause of that problem.

Loading...