Clean up goal description messages.

Review Request #232 — Created April 15, 2014 and submitted

benjyw
pants
pants-reviews
lahosken
- Make them more concise.
- Make them all use imperative mood.
- Make them all end with periods.
- Fix some formatting nits.

`./pants goal` looks a lot nicer now.


LA
  1. LGTM. Some "maybe think about"-ish comments I bumped into along the way...
  2. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    Without "published from this BUILD tree", I  worry that folks'll optimistically assume this catches artifacts published from elsewhere. I don't have science behind that worry; just vague apprehension
  3. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    the default output doesn't feel so graphical. Maybe:
    
    Depict the target's dependencies.
    
    ...and let folks notice there's dot output available in the options?
  4. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    I confess I don't really understand this (with or without the "input"). I'm happy with this change, FWIW.
  5. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    Assuming this goal works even if my code is *gasp* not under source control...
    
    Maybe s/repo/source tree/
    
    or maybe s/repo's //
    
    or maybe repo's is fine.
  6. 
      
BE
  1. Thanks for the quick review. PTAL.
  2. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    Don't forget that there is (or should be, or will be) help for each goal. That's where details should go. These should be a very terse half-statement to tell you which garden path to go down for more info.
  3. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    SG. Changed.
  4. src/python/pants/commands/goal.py (Diff revision 1)
     
     
    I went with 'workspace'. Source tree implies a single root...
  5. 
      
LA
  1. > Source tree implies a single root
    
    oh man. Good catch.
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...