Refactoring ProtobufGen to use SimpleCodeGen.

Review Request #2302 - Created June 1, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/protobuf-simple-codegen
121, 1613
452358a...
Reviewers
pants-reviews
jsirois, patricklaw, zundel

Drops python support at jsirois's suggestion. The python
code-gen sections of ProtobufGenwere dropped due to
disuse and poor semantics (since it was generating python
code from java_protobuf_libraries).

Test-cases were modified to accomodate modified output due to
generating fewer languages.

I had to modify jar_publish slightly to pass an integration test in
jar_publish_integration that was publishing jars created from protoc
libraries (see my new comment in that file).

Added/modified test-cases in test_protobuf_gen and test_protobuf_integration.

Passed CI previously, before rebasing with master. (Waiting to hear back on rebased commit).

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Eric Ayers
Garrett Malmquist
Eric Ayers
Eric Ayers
Garrett Malmquist
Garrett Malmquist
John Sirois
John Sirois
Garrett Malmquist
John Sirois
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Loading...