Spindle contrib plugin builds and distributes as part of the release process

Review Request #2301 — Created June 1, 2015 and submitted

patricklaw
pants
1620
ccea65f...
pants-reviews
benjyw, jsirois, zundel
Spindle contrib plugin builds and distributes as part of the release process

CI is green at https://travis-ci.org/pantsbuild/pants/builds/64963622

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
ZU
  1. I went through the contrib README and it looks good to me. Did you test with ./build-support/bin/release.sh -n ?

    1. Technically no need to - CI does this.
  2. 
      
JS
  1. 
      
  2. contrib/release_packages.sh (Diff revision 1)
     
     
    This should fail - you need to pass "extra_backend_packages='...'" like the scrooge plugin does above.
    1. Good eye. Unfortunately it's still failing, and I still have no idea why because there's no output from the release script upon failure.

    2. Oops, hold on that--I hadn't changed scrooge to spindle after my copy paste!

      But it would be nice to modify these scripts to dump traces on failure. I've been debugging this blind, and my bash-fu is not really up to fixing the script properly. Maybe it's time to hoist these into python?

    3. Nice, and that did indeed fix my local failure. Pushing the fix to my branch now for CI to pick up.

  3. 
      
PA
JS
  1. Ship It!
  2. 
      
PA
PA
Review request changed

Status: Closed (submitted)

Change Summary:

Upstream @ 829676b33db6a178dff1e41e95161da353650241

BE
  1. Ship It!
  2. 
      
Loading...