Restore the explicit identity conf mappings.

Review Request #229 — Created April 15, 2014 and submitted

jsirois
pants
jsirois/resolve/fix_conf_mapping
59
pants-reviews
benjyw, tejal
commit dae59ac52dcacf16dc6e53865a5eeab83bf0875d
Author: John Sirois <jsirois@twitter.com>
Date:   Tue Apr 15 14:21:44 2014 -0700

    Restore the explicit identity conf mappings.
    
    It looks like the absence of an explicit mapping
    behaves like a '*' mapping.

 src/python/pants/tasks/templates/ivy_resolve/ivy.mustache | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Master is ci green before https://github.com/pantsbuild/pants/commit/67a6dbdcc90b098e3d0f81ad36eeae172c8a6cb1 and that change only intersected ivy resolution in the mustache template.
Despite docs that imply no mapping -> mapping="${conf name}" [1] It appears ivy actually does no mapping -> mapping="*".

[1] https://ant.apache.org/ivy/history/2.3.0/ivyfile/dependency-conf.html

With this patch local ./build-support/bin/ci.sh passes and the resolved classpaths are now source and javadoc jar free. 
TE
  1. Ship It!
  2. 
      
JS
  1. Thanks - merged
  2. 
      
BE
  1. Ship It!
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...