Extract a ThriftDefaults subsystem.

Review Request #2288 - Created May 28, 2015 and submitted

Information
John Sirois
pants
jsirois/thrift_options/cleanup
1607
ec32007...
Reviewers
pants-reviews
patricklaw, stuhood, zundel
This lifts out responsibility for dealing with default thrift
compiler options for java_thrift_library targets to a subsystem.

 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/BUILD                                                   |  1 +
 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/java_thrift_library_fingerprint_strategy.py             | 23 +++++++--------
 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py                                          | 39 ++++++++++---------------
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/BUILD                                            |  1 +
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_java_thrift_library_fingerprint_strategy.py | 59 +++++++++++++++++--------------------
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py                              | 21 +++++++-------
 migrations/options/src/python/migrate_config.py                                                                |  4 +++
 src/python/pants/backend/codegen/subsystems/BUILD                                                              | 11 +++++++
 src/python/pants/backend/codegen/subsystems/__init__.py                                                        |  0
 src/python/pants/backend/codegen/subsystems/thrift_defaults.py                                                 | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/python/pants/backend/codegen/tasks/BUILD                                                                   |  1 +
 src/python/pants/backend/codegen/tasks/apache_thrift_gen.py                                                    | 15 ++++++----
 src/python/pants/option/global_options.py                                                                      |  8 -----
 tests/python/pants_test/backend/codegen/subsystems/BUILD                                                       | 21 ++++++++++++++
 tests/python/pants_test/backend/codegen/subsystems/__init__.py                                                 |  0
 tests/python/pants_test/backend/codegen/subsystems/test_thrift_defaults.py                                     | 64 ++++++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/base/context_utils.py                                                                  |  3 ++
 17 files changed, 257 insertions(+), 93 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/64490242
John Sirois
John Sirois
Fedor Korotkov
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...