Integrating Patrick's SimpleCodegenTask base class with WireGen.

Review Request #2274 - Created May 27, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/wire-simple-codegen
1597
1a3e1a2...
Reviewers
pants-reviews
jsirois, patricklaw, zundel

Refactors of other codegen classes omitted in this patch for
simplicity; I will circle back and add Jaxb and Protobufs in a
new review once this patch goes through.

There are some TODO's for integrating isolated code-generation
strategies (the real motivation behind simplifying codegen),
which I will also circle back and replace with real code after
landing this patch.

test tests/python/pants_test/backend/codegen/tasks:wire_gen passes,
test tests/python/pants_test/tasks:wire_integration passes,
CI is green.

I updated the wire test-cases a bit, including adding a unit test for sources_generated_by_target. I also added another .proto to the wire/elements example, and updated the corresponding integration test, to insure codegen works properly with multiple .proto files in the same target.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Mixins on the left! Patrick Lawson Patrick Lawson
Garrett Malmquist
Eric Ayers
John Sirois
Eric Ayers
John Sirois
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Patrick Lawson

   

Mixins on the left!

  1. Already merged, but will fix shortly in my next review which builds off this one.

Loading...