Two changes that affect invalidation and artifact caching.

Review Request #2269 - Created May 26, 2015 and submitted

Information
Benjy Weinberger
pants
1595
0a02cf5...
Reviewers
pants-reviews
jsirois
1. Don't use the task class name in cache paths. This name may not
   be stable across runs because we generate synthetic subclasses at runtime,
   and we make no guarantees about their names (e.g., in tests we inject a
   uuid into the synthetic subclass's name). Instead we introduce a
   stable name, based on the non-synthetic, authored class's name.
   Note that this will all go away once we no longer have any class-level
   task state at runtime.

2. Don't use the registration key or option scope in the cache keys of
   JVM tools. They aren't needed - those are just how the tool is accessed
   by code, they have no effect on which tool jars are resolved or how
   those are shaded.

Both these changes will enable us to get huge test performance speedups by having
tests share shaded JVM tool jars via the local artifact cache.

Unit tests pass locally.
CI passes: https://travis-ci.org/pantsbuild/pants/builds/64289095.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
John Sirois
Benjy Weinberger
John Sirois
Benjy Weinberger
John Sirois
Benjy Weinberger
John Sirois
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks John! Submitted as ea5dd35cc46de159082d423eaa2aeec7ae8f401c.

Loading...