Adds a product to bundle_create

Review Request #2254 — Created May 21, 2015 and submitted

zundel
pants
zundel/bundle-product
1582
a806620...
pants-reviews
benjyw, dturner-tw, jsirois

Similar to https://rbcommons.com/s/twitter/r/2172/ this will help any 3rdparty plugins that want to wait for the bundle step to complete.

CI running at https://travis-ci.org/pantsbuild/pants/builds/63513878

ZU
  1. 
      
  2. Also, this got left out of the previous commit to add a product to binary_create.py

  3. 
      
BE
  1. 
      
  2. 
      
JS
  1. 
      
  2. The basedir is under the dist/ dir making this the 1st product I'm aware of not housed/controlled under .pants.d/.  I don't think this is currently a problem since bundle rebuilds the bundle on every run - so any user-tampering with the dist dir between pants runs has no effect here as things stand.  May be worth a TODO though.
  3. 
      
ZU
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews Benjy & John. Commit 3f23cb1

Loading...