[pants/jar] Fix a typo

Review Request #2230 — Created May 15, 2015 and submitted

sserebryakov
pants
sserebryakov/jar/typos
1556
1c6fd82...
pants-reviews
fkorotkov, jsirois, kwlzn

Expected reviewers: jsirois, kwizn

Just fixing some typos to see how hard would it be to ship a change.

Green CI: https://travis-ci.org/pantsbuild/pants/builds/62773160

JS
  1. LGTM after a revert noted below.
    
    The summary, description and testing done fields of the RB form the commit message when we patch in reviews using `rbt patch -c ...`  Its best to write them with the commit message in mind.  For your testing done, you could just point out the CI went green here: https://travis-ci.org/pantsbuild/pants/builds/62668365
    
    That said - the OOM is not expected for running the tests themselves on a dev machine.  I suspect you have other things going on.  Perhaps many long lived nailguns are up?
  2. This was correct as it stood - this is a FileSource with a directory parameter (as opposed to the FileSource with a file parameter returned by the fileSource method above.
    1. Yeah, I was second-guessing myself because there is fileSource() but also memorySource(). Reverted.

  3. 
      
SS
JS
  1. Thanks Sergey - submitted @ https://github.com/pantsbuild/pants/commit/9f26b098703f41a860c1359e5effc8cb9390e9eb
    Please mark this review as submitted.
  2. 
      
SS
Review request changed

Status: Closed (submitted)

Loading...