Read backend and bootstrap BUILD file settings from options instead of config.

Review Request #2229 — Created May 14, 2015 and submitted

benjyw
pants
1554
b2a730d...
pants-reviews
jsirois, zundel
Read backend and bootstrap BUILD file settings from options instead of config.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/62761102

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. 
      
  2. Unless there is magic I don't know about, this should default to None and blow up the loop in goal_runner.py setup for installations with no bootstrap BUILD files defined.
    1. Oops, yes, I was laboring under the delusion that the default default is [], not None. Fixed.

  3. It turns out None is handled for both of these options if I walked the code paths correctly, but might be worth a second set of eyes if you did not already examine this.
    1. Yes, these can be None, I just verified.

  4. 
      
BE
JS
  1. Ship It!
  2. 
      
BE
ZU
  1. 
      
  2. Not really relevant to this review, but is source root registration the only reason to have BUILD files that always get scanned?

    1. Yup.
    2. Should probably be config of some sort? And in many cases we can probably infer it from path names.

  3. 
      
BE
BE
ZU
  1. Still LGTM

  2. 
      
JS
  1. Ship It!
  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks John and Eric! Submitted as e325cf77311e9a542a22c1b78e5cac518b83fcf4.

Loading...