Kill scala specs support.

Review Request #2208 — Created May 12, 2015 and submitted

jsirois
pants
jsirois/scala_specs/kill_support
1535
2209
1124cc2...
pants-reviews
benjyw, fkorotkov, zundel
Scala specs has been long abandoned as a framework; all new development
is done in the Specs2 [1] projects.  No pants users reported [2] using
this feature so this change guts support.

[1] https://etorreborre.github.io/specs2/
[2] https://groups.google.com/d/topic/pants-devel/sc2jaZ9YZGU/discussion

 BUILD                                                   |  4 +--
 BUILD.tools                                             |  9 ------
 examples/src/java/org/pantsbuild/example/readme.md      |  8 ++---
 examples/src/scala/org/pantsbuild/example/readme.md     |  6 ++--
 src/docs/first_concepts.md                              | 10 +++---
 src/python/pants/backend/core/tasks/reflect.py          |  4 ---
 src/python/pants/backend/jvm/register.py                |  5 ---
 src/python/pants/backend/jvm/targets/BUILD              |  1 -
 src/python/pants/backend/jvm/targets/scala_tests.py     | 16 ----------
 src/python/pants/backend/jvm/tasks/BUILD                | 17 +----------
 src/python/pants/backend/jvm/tasks/specs_run.py         | 82 --------------------------------------------------
 src/python/pants/backend/maven_layout/maven_layout.py   |  3 +-
 src/python/pants/backend/project_info/tasks/idea_gen.py |  3 +-
 src/python/pants/docs/internals.md                      |  2 +-
 14 files changed, 17 insertions(+), 153 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/62293330
ZU
  1. There is still a definition in 3rdparty/BUILD that looks scala spec related:

    jar_library(name='specs',
                jars=[
                  jar('org.scala-tools.testing', 'specs_2.10', '1.6.9')
                ])
    

    And there is a reference to it in ./examples/tests/scala/org/pantsbuild/example/hello/welcome/BUILD: '3rdparty:specs'

    I'm guessing this is still needed to run scala specs with JunitSuiteRunner

    1. Yes - exactly: https://github.com/pantsbuild/pants/blob/master/examples/tests/scala/org/pantsbuild/example/hello/welcome/Welcome.scala#L9
      Its in fact used as an example of running a scala test framework test using junit: https://pantsbuild.github.io/scala.html#hello-pants-scala

  2. 
      
BE
  1. So much glorious red!

  2. 
      
JS
JS
  1. Thanks guys - submitted @ https://github.com/pantsbuild/pants/commit/f7a23592347dc4094d531dd385cf61442466af97
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...