Use the default ivysettings.xml provided by ivy.
Review Request #2204 - Created May 12, 2015 and submitted
|benjyw, nhoward_tw, zundel|
The pantsbuild/pants repo no longer has any dependencies in the maven.twttr.com repo and so can just use the default ivysettings.xml embedded in the ivy jar itself for all resolution. This required replacement of the custom libthrift hosted at maven.twttr.com with an un-optimized/un-bugfixed one published by hadoop. This includes a breaking change to installations relying on the default location of a custom ivysettings.xml. A placeholder note is added in the CHANGELOG to save space for warning users. 3rdparty/BUILD | 17 ++++++++-- build-support/ivy/ivysettings.xml | 84 -------------------------------------------------- build-support/ivy/publish.ivysettings.xml | 6 ++-- src/python/pants/CHANGELOG.rst | 14 +++++++++ src/python/pants/ivy/ivy_subsystem.py | 2 -- tests/python/pants_test/ivy/test_bootstrapper.py | 4 +-- 6 files changed, 34 insertions(+), 93 deletions(-)
rm -r ~/.ivy2/pants && ./build-support/bin/ci.sh.
I also ran a local publish verifying maven2 resolver in
build-support/ivy/publish.ivysettings.xml still worked for resolving
the generated pom dep lists.
CI went green here:
I missed this change because I was on vacation for a couple weeks. I am pushing an update to #2040 which relies on custom ivysettings for the built-in m2 repos that are installed in the Android SDK. I just pushed that update but with the ivysettings.xml simply added back.
John, when you get a chance to look over the update to #2040 could you let me know what the preferred way of addressing this would be? Thanks!