Eliminate the globs.__sub__ use in option package.

Review Request #2197 - Created May 10, 2015 and submitted

Information
John Sirois
pants
jsirois/globs_sub/address_deprecation
1520
a4efd06...
Reviewers
pants-reviews
benjyw, dturner-tw, nhoward_tw, zundel
This leaves a target alias in-place for those used to it but moves the
migration tool to the migrations tree.

 migrations/options/src/python/BUILD                                          | 12 ++++++++++++
 {src/python/pants/option => migrations/options/src/python}/migrate_config.py |  0
 src/python/pants/option/BUILD                                                | 17 +++++++----------
 3 files changed, 19 insertions(+), 10 deletions(-)

https://rbcommons.com/s/twitter/r/2082/ deprecated +/-, but missed cleaning up pants itself:

$ ANTS_DEV=1 ./pants list src/python/pants/option/:
*** Running pants in dev mode from /home/jsirois/dev/3rdparty/pants/src/python/pants/bin/pants_exe.py ***
WARN] <string>:6: DeprecationWarning: 
pants.backend.core.wrapped_globs.__sub__ is deprecated and will be removed in version 0.0.35:
Instead of glob arithmetic, use glob(..., exclude=[...])

INFO] Detected git repository at /home/jsirois/dev/3rdparty/pants on branch master
src/python/pants/option:migrate_config
src/python/pants/option:option

After the fix deprecation is gone and the options migration tool still works:

$ rm -r dist/ && PANTS_DEV=1 ./pants binary src/python/pants/option:migrate_config
$ ./dist/migrate_config.pex 
Checking config file at ./pants.ini for unmigrated keys.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/62009350

Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

David Turner
Ship It!
Benjy Weinberger

   
src/python/pants/option/BUILD (Diff revision 1)
 
 

I'd be fine removing this entirely, btw.

Loading...