Replace custom softreference cache with a guava cache.

Review Request #2190 - Created May 9, 2015 and submitted

Information
Stu Hood
pants
ed6f103...
Reviewers
pants-reviews
benjyw, fkorotkov, jsirois, nhoward_tw
  • Replace custom softreference cache with a guava cache

The cache for analysis shows up as highly contended after the other analysis fixes. This replaces the custom cache with a guava softreference cache, which defaults to being striped for 4 writers, and which allows concurrent reads.

org.pantsbuild;zinc#1.0.1:
main:compile:jvm:jvm-compilers:compile:zinc: 448.450177431
this patch:
main:compile:jvm:jvm-compilers:compile:zinc: 412.523220778

Stu Hood
John Sirois
John Sirois
Stu Hood
Stu Hood
Review request changed

Status: Closed (submitted)

Loading...