Move ads/common/retry python decorator into commons

Review Request #219 — Created April 14, 2014 and discarded

ddavydov
commons
pants-reviews
jsirois, tejal, travis
See DPB-1519 (in our internal bug-tracking system).

I need some Twitter code that is currently not open-sourced to be open sourced in order to be able to use it in the open source pants branch. I would like to push the code as is since I am not the author of this code, and this code has already passed a review process (I just copied it from an internal repo, other than the BUILD file changes). This is a review containing only the code I need for my upcoming pants patch, but not the pants patch itself (which will go to the pants repo)
./pants tests/python/twitter/common/decorators                               
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Add Headers. TE tejal
TE
  1. 
      
  2. Add Headers.
  3. 
      
DD
  1. Bump because this was invisible before due to my email being @twitter.com
  2. 
      
JS
  1. Where do you need to use this - aka will common_internal suffice?
    1. I need to use it in: science:src/python/twitter/twadoop/pants/targets/remote_file_fetcher.py
      
      Speaking of which, I didn't see this file in the open source version of pants, so I want to confirm that the cgit thrift fetching will be ported to open source pants from science pants.
    2. Never mind Travis explained everything to me (thanks by the way!).
    3. Ok so I agree this belongs in common_internal, but it looks like pants_internal does not currently have a dependency on common_internal or Science for that matter. Should I go ahead and figure out how to add this dependency to pants_internal (which is where I need this code)?
  2. 
      
JS
  1. Is this discardable?  If so please mark discarded.
  2. 
      
DD
DD
DD
Review request changed

Status: Discarded

Loading...