Have ConsoleRunner halt(1) on exit(x)

Review Request #2180 - Created May 8, 2015 and submitted

Information
Stu Hood
pants
1f0af0c...
Reviewers
pants-reviews
benjyw, fkorotkov, jsirois, nhoward_tw, zundel
  • Have ConsoleRunner halt() on exit()

This defends against the case where a System.exit(0) causes junit to exit "cleanly" without having actually torn anything down or reported other failing tests. It was discovered when folks noticed that their tests were exiting successfully despite having E entries in the output.

deployed internally, and tested on cases involving System.exit

Fedor Korotkov
Eric Ayers
Nick Howard (Twitter)
Stu Hood
Review request changed

Status: Closed (submitted)

Benjy Weinberger

So that's why that happens! Great fix.

  1. Nick detected it initially, so the credit goes to him!

Loading...