memoize linkify to reduce reporting file stat calls

Review Request #2170 - Created May 6, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1498
d4a0736...
Reviewers
pants-reviews
benjyw, dturner-tw, stuhood, zundel
- adds memo to linkify
- use from_cache on build file usage in linkify
- store memo in html reporter

when doing an incremental compile, for some targets, stating files for doing link substitution was taking 50% or more of the total time. memoizing the results of substitutions bought some of that back

ran against targets, saw speed improvement, ran unit tests including a test of the memoization. CI baking off of PR.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Nick Howard (Twitter)
Benjy Weinberger
Eric Ayers
Nick Howard (Twitter)
Eric Ayers
Nick Howard (Twitter)
Eric Ayers
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/c02db3dc7ec06459224c8b0fb4e0bf15093ed3e5

Loading...