fix bug in bundle_create with missing path

Review Request #2157 - Created May 4, 2015 and submitted

Information
David Turner
pants
56cf009...
Reviewers
pants-reviews
patricklaw, zundel
fix bug in bundle_create with missing path

CI running: https://travis-ci.org/pantsbuild/pants/builds/61219190

New test was red; is now green.

Patrick Lawson
David Turner
Patrick Lawson
Eric Ayers
David Turner
Eric Ayers
David Turner
David Turner
David Turner
Review request changed

Status: Closed (submitted)

Benjy Weinberger

This still fails for me:

E Exception message: Given path: data/no-such-file with absolute path: /Users/benjy/src/pants/testprojects/src/java/org/pantsbuild/testproject/bundle/data/no-such-file which does not exist E while executing BUILD file /Users/benjy/src/pants/testprojects/src/java/org/pantsbuild/testproject/bundle/BUILD E Loading addresses from 'testprojects/src/java/org/pantsbuild/testproject/bundle' failed.

  1. That test is supposed to fail. Its listed in the negative test cases in ci.sh

  2. I don't see that in ci.sh. I do see testprojects/src/java/org/pantsbuild/testproject/bundle:missing-files excluded, but the test I'm referring to is  tests/python/pants_test/targets:jvm_app.
    
    This test runs when you run ./pants test tests/python/pants_test:all, so it should not fail, deliberately or otherwise.
Eric Ayers

   
tests/python/pants_test/targets/BUILD (Diff revision 5)
 
 

This line needs to be removed - this is an integration test so it shouldn't be listed in the default target.

Eric Ayers

   
tests/python/pants_test/targets/BUILD (Diff revision 5)
 
 

THis should be named jvm_app_integration so it gets picked up as an integration test from ci.sh

Loading...