An anonymizer for analysis files.

Review Request #214 — Created April 12, 2014 and submitted

benjyw
pants
pants-reviews
patricklaw
Useful for creating scrubbed test data.

May be useful for scrubbing source files in the future.
It successfully anonymized 68 analysis files totaling 10MB (uncompressed) that were then used in a test.
PA
  1. 
      
  2. This seems to imply that it ought to be in its own leaf directory.
  3. I'm a fan of using free functions instead of static methods unless they very specifically need the extra namespace information (more than is given by the module)
    1. I prefer to scope things like this, especially since this method is only for use inside this class (I changed its name to start with underscore, to emphasize this). 
  4. The lambda is superfluous.  You can just pass the method, i.e. `filter(Anonymizer._WORD_RE.match, word_list)`
  5. More descriptive variable name?
  6. Descriptive variable.  I assume `s` should be `token`
  7. 
      
PA
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...