Make exclude_target_regexp option recursive
Review Request #2136 - Created April 29, 2015 and submitted
Otherwise overrides in subtask configs do nothing.
I'm in support of the idea of change, but I want to point out how limited the use is for making this option recursive. Currently, I can find only 2 places that we actually read this value. That is insrc/python/pants/bin/goal_runner.py: exclude_target_regexps=self.global_options.exclude_target_regexp) src/python/pants/backend/core/tasks/what_changed.py: exclude_target_regexp=options.exclude_target_regexp,
The goal_runner change is the one that does the bulk of the work. This is done outside of the task logic (before any tasks run), so any override on a per task basis isn't going to have an effect.
I'm guessing you want to have an effect on the
changedgoal. This makes sense for the
what_changedtask because it doesn't take any targets as arguments so it skips over the logic in goal_runner. So, effectively, we can add an override, but it can only ever work as expected on a minority of tasks (currently just this one).