Cleanup analysis left behind from failed isolation compiles

Review Request #2127 - Created April 26, 2015 and submitted

Information
Stu Hood
pants
4009964...
Reviewers
pants-reviews
benjyw, jinfeng, nhoward_tw
  • Cleanup analysis left behind after failed compiles, because it triggers the "Cleaning up invalid analysis" warning before the next attempt.

new integration test to check that a failing target doesn't leave analysis behind
https://github.com/pantsbuild/pants/pull/1457

Issues

  • 1
  • 1
  • 0
  • 2
Description From Last Updated
Presumably this is a zinc bug? Analysis files should never be broken. Oh, which reminds me, could you change the ... Benjy Weinberger Benjy Weinberger
Nick Howard (Twitter)
Stu Hood
Review request changed

Status: Closed (submitted)

Benjy Weinberger

   

Presumably this is a zinc bug? Analysis files should never be broken.

Oh, which reminds me, could you change the phrasing here to replace "invalid" with "broken", or some other synonym? "invalid analysis" has a specific meaning in jvm compilation, namely "analysis of invalidated targets". I got confused at first when reading this.

Loading...