Cleanup analysis left behind from failed isolation compiles
Review Request #2127 — Created April 27, 2015 and submitted
|benjyw, jinfeng, nhoward_tw|
- Cleanup analysis left behind after failed compiles, because it triggers the "Cleaning up invalid analysis" warning before the next attempt.
new integration test to check that a failing target doesn't leave analysis behind
|Presumably this is a zinc bug? Analysis files should never be broken. Oh, which reminds me, could you change the ...||benjyw|
Revision 2 (+54 -12)
Presumably this is a zinc bug? Analysis files should never be broken.
Oh, which reminds me, could you change the phrasing here to replace "invalid" with "broken", or some other synonym? "invalid analysis" has a specific meaning in jvm compilation, namely "analysis of invalidated targets". I got confused at first when reading this.