Cleanup analysis left behind from failed isolation compiles

Review Request #2127 — Created April 27, 2015 and submitted

stuhood
pants
4009964...
pants-reviews
benjyw, jinfeng, nhoward_tw
  • Cleanup analysis left behind after failed compiles, because it triggers the "Cleaning up invalid analysis" warning before the next attempt.

new integration test to check that a failing target doesn't leave analysis behind
https://github.com/pantsbuild/pants/pull/1457

  • 1
  • 0
  • 1
  • 0
  • 2
Description From Last Updated
Presumably this is a zinc bug? Analysis files should never be broken. Oh, which reminds me, could you change the ... benjyw
  1. One nitpick about raise, other than that lgtm.

  2. I think you want to use just raise here. raise e changes the traceback so that it starts from here instead of from whereever the initial exception came from.

  3. 
      
Review request changed

Status: Closed (submitted)

  1. 
      
  2. Presumably this is a zinc bug? Analysis files should never be broken.

    Oh, which reminds me, could you change the phrasing here to replace "invalid" with "broken", or some other synonym? "invalid analysis" has a specific meaning in jvm compilation, namely "analysis of invalidated targets". I got confused at first when reading this.

  3. 
      
Loading...