Change ZincAnalysis{Parser} to be a thin wrapper around external zincutils.

Review Request #2125 - Created April 24, 2015 and submitted

Information
Benjy Weinberger
pants
c9501d3...
Reviewers
pants-reviews
davidt, patricklaw, stuhood, zundel

I split the zinc parse/split/merge logic out into pantsbuild/zincutils so we
can easily iterate on optimizing it. In particular, if we want to replace part/all
of it with native code, that will be harder to do in pantsbuild/pants, as pants
doesn't yet support building and packaging native code.

This commit turns ZincAnalysis and ZincAnalysisParser into adapters that wrap
that standalone code and adapt it to pants's Analysis/AnalysisParser class hierarchy.

In the future we can consider moving the zinc split/merge code back into the mainline
pantsbuild/pants repo, once we're happy with performance and have a decent way to
build/deploy it.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/59924368

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Taylor
Stu Hood
Eric Ayers
Stu Hood
Benjy Weinberger
Stu Hood
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 8c4f6bc48da780fe9be5748cccc4c10e39562dce.

Loading...