Provide global option to look up BUILD files in git history

Review Request #2121 - Created April 24, 2015 and submitted

Information
David Turner
pants
d359d16...
Reviewers
pants-reviews
benjyw, nhoward_tw, patricklaw, stuhood, zundel

Provide global option to look up BUILD files in git history

The ultimate goal here is to support a pants filedeps command that can
generate the necessary data for git sparse checkouts of the just the
data necessary to build a specific target. To do this, we need to be
able to use the filedeps goal with BUILD files that we haven't checked out
(since we don't want to have to check out all the BUILD files only to
throw most of them away).

The changes to the java_tests target are necessary because otherwise
we'll crash while generating the sparse-checkout data if we don't
happen to have any source files checked out yet. Of course, we could
make it, too, operate on the in-repo data, but that would be a massive
amount of complexity. Instead, we simply wait until test time to
complain.

CI green: https://travis-ci.org/pantsbuild/pants/builds/60741897

Issues

  • 1
  • 15
  • 2
  • 18
Description From Last Updated
This check broke us internally, and as far as I can tell, it is logically incorrect. Moreover, app does not ... Patrick Lawson Patrick Lawson
David Turner
Stu Hood
Benjy Weinberger
Eric Ayers
Stu Hood
David Turner
Stu Hood
Eric Ayers
David Turner
Eric Ayers
David Turner
Nick Howard (Twitter)
David Turner
David Turner
Nick Howard (Twitter)
David Turner
Stu Hood
David Turner
Review request changed

Status: Closed (submitted)

Patrick Lawson

   

This check broke us internally, and as far as I can tell, it is logically incorrect. Moreover, app does not have a target attribute.

  1. There was a check similar to this in JvmApp.__init__() before, but it was intended to check the rel_path argument passed into the jvm_app target, not the bundle output directory.

    Should app.target have been app.address.spec? It would be great to include a unit test with the fix for this exception. Davida already added a test project for the other case where sources are missing.

Loading...