Address Stu's comment from https://rbcommons.com/s/twitter/r/2084

Review Request #2119 - Created April 24, 2015 and submitted

Information
Eric Ayers
pants
zundel/fixup-jvm-binary-task
1452
313ff15...
Reviewers
pants-reviews
stuhood

There was an unintentional indent when adding new context manager for self.create_jar_builder()

git diff HEAD~20 src/python/pants/backend/jvm/tasks/jvm_binary_task.py
diff --git a/src/python/pants/backend/jvm/tasks/jvm_binary_task.py b/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
index 50787d0..518507a 100644
--- a/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
+++ b/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
@@ -69,7 +69,8 @@ class JvmBinaryTask(JarTask):
                          compressed=True) as jar:

         with self.context.new_workunit(name='add-internal-classes'):
-          self.create_jar_builder(jar).add_target(binary, recursive=True)
+          with self.create_jar_builder(jar) as jar_builder:
+            jar_builder.add_target(binary, recursive=True)

         if with_external_deps:
           with self.context.new_workunit(name='add-dependency-jars'):
Eric Ayers
Stu Hood
Eric Ayers
Stu Hood
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Stu. Commit 0902530

Loading...