Rename package from com.sun.tools to org.pantsbuild

Review Request #2056 — Created April 10, 2015 and submitted

zundel
jmake
zundel/refactor-package
20
f2b1d94...
pants-reviews
dturner-tw, jsirois

Rename package from com.sun.tools to org.pantsbuild. We have been using jarjar to rename the package. It turns out that you cannot easily debug analysis files built with pants because the java deserialization for ClassInfo fails (looking for the wrong package.)

Used Intellij to refactor the package, then hand edited rename.rules and one test which had the path to jmake source code hard coded.

ant test

JS
  1. 
      
  2. src/org/pantsbuild/jmake/Main.java (Diff revision 1)
     
     
    Its probably fine that the next release can only be used by those who also upgrade pants, but throwing out keeping a `src/com/sun/tools/jmake/Main.java` main that forwards all args to this main with a warning to stderr or somesuch.
    1. You mean Pants users or other users? Pants users won't see a change because Pants has already been updated to reference org.pantsbuild.jmake.Main.

      https://github.com/pantsbuild/pants/blob/9514990ef3d6e24aaa747e96ed4069cf4e43824a/src/python/pants/backend/jvm/tasks/jvm_compile/java/java_compile.py#L49

    2. Ah yes - the jarjar rule edit in this RB undid that since its the real name now.  Sorry about that - lgtm.
  3. 
      
DT
  1. Ship It!
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews John & David. Commit 22074a2

Loading...