Further cleanup of test context setup.

Review Request #2053 - Created April 10, 2015 and submitted

Information
Benjy Weinberger
pants
42d22db...
Reviewers
pants-reviews
jsirois, zundel
- Make the context creation arguments explicit, so that more deps
  don't creep back in via **kwargs.
- Make the signature of context() the same in subclasses of
  BaseTest as in the base class, for hygiene.
- Emphasize that in tests context.config is now an empty config.

Tests pass locally, CI passes: https://travis-ci.org/pantsbuild/pants/builds/57973472.

John Sirois
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as fcf80bd3c3c06ce22fffaceb876f84f36a0ea170.

Eric Ayers

   

I don't have a problem with you removing this, but keep in mind that some IDEs (Intellij) parse the pydoc for type information so its not all just for the benefit of human readers. I've gone in and paid special attention in some places to set the type names on ":param" entries as well as ":type" and ":rtype" to help out the IDE.

  1. I'm hoping to slimline this even further. But once it settles down I'll be happy to add the annotations (although we don't really enforce them throughout the codebase, and probably should)

Loading...