Include classifier in JarDependency equality / hashing

Review Request #2029 - Created April 3, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1366
391a4a8...
Reviewers
pants-reviews
ity, jinfeng, jsirois, zundel

https://rbcommons.com/s/twitter/r/1905 made it so that calculate_classpath included classifiers in the keys of a dict it was using, but there are a number of places where JarDependencys are put in sets or are compared for equality and those didn't take classifer into account. This changes JarDependency's comparison ops to use classifier. It also moves validation of artifact / classifier into the __init__ definition so that they happen during definition rather than deep in an ivy resolve.

Changing the operators was a little tricky because there's some pants ivy code that relies on IvyModuleRefs duck typing as JarDependencys. I'm not completely sure of the effect there because it's possible that the ModuleRefs have classifiers nested in the associated artifacts. If someone else has thoughts around that I'd appreciate some suggestions.

ran ci.sh locally, travis baking off of a PR

Issues

  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Stu Hood
Nick Howard (Twitter)
Stu Hood
Ity Kaul
Nick Howard (Twitter)
Stu Hood
Eric Ayers
Nick Howard (Twitter)
Nick Howard (Twitter)
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted 63fc8edec927e417dbb8b75468d090d4d688c3f7

Loading...