Added a simple 'HelloWorld' java example

Review Request #2028 — Created April 3, 2015 and submitted

zundel
pants
zundel/simple-hello-world
1180, 1365
d0d8376...
pants-reviews
areitz, jsirois, lahosken

Added a simple 'HelloWorld' java example. This can be quickly used to demonstrate different issues in pants without the complexities of the examples/src/java/com/pants/examples/hello/main target that is used to demonstrate more features of pants, like bundling, resources, etc.

./pants run examples/src/java/com/pants/examples/hello/simple

Ran ./build-support/bin/publish_docs.sh and looked at the first_tutorial page.

AR
  1. LGTM, thanks for doing this.

    How do you feel about adding a bit about this here:

    https://github.com/pantsbuild/pants/blame/master/src/docs/first_tutorial.md#L283

    Just give an example of "./pants run" of this target?

  2. I took this out and checkstyle didn't barf, is it really needed?

    1. no, I removed it. I don't think the checkstyle goal is wired up in OSS pants.

    2. Okay, interesting, didn't know that. I ran "./pants compile.checkstyle" on that target and it was okay. Maybe we're just missing the rules or some other config.

  3. 
      
ZU
AR
  1. Ship It!
  2. 
      
JS
  1. Ship It!
  2. 
      
ZU
  1. I did a push to master without looking carefully at the travis run (what could possibly go wrong?) and just had to quickly revert this change as I noticed one of the idea tests is broken. I'll fix it and re-push.

  2. 
      
ZU
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews Andy & John. Commit 718629e.

Loading...