Upgrade all ConsoleTask tests to TaskTestBase.

Review Request #2022 — Created April 2, 2015 and submitted

benjyw
pants
b227c70...
pants-reviews
jsirois, zundel

While in those files, also replaced all % formats with format(),
and made a few other style changes.

It's a large-ish, but 95% mechanical change.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/57014861.

JS
  1. 
      
  2. This caught my eye as off from project style and pep8 derides the extra space here as a pet-peeve: https://www.python.org/dev/peps/pep-0008/#pet-peeve.  Lots of these in this review.
    1. Fixed them all via grep.

  3. A reminder that {} works for positional as long as you're not doing repeats or out-of order interpolation.  Many of these in this review.
    1. I prefer to always use an index or keyword for this, as it's slightly more future-error-proof.

  4. 
      
ZU
  1. 
      
  2. This changes the code. --spec-excludes isn't registered recursively. Will it still be picked up?

    1. Yes. recursive=True means that the option can be set to a different value on an inner scope. But values are always applied recursively, so you can always read the outer scope's value as-if in your scope.

  3. 
      
BE
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as c4680853e4ea9be345f8ca6fff43b96aa703cec4.

Loading...