Migrating more data to payload fields in jvm_app and jvm_binary targets

Review Request #2011 - Created March 31, 2015 and submitted

Information
Eric Ayers
pants
zundel/update_jvm_binary_payload
1349
007af85...
Reviewers
pants-reviews
jsirois, nhoward_tw, patricklaw
  • All fields custom to jvm_binary and jvm_app should now be reflected in the payload.
  • Added more tests to test_jvm_binary and test_jvm_app
  • Made tests for exceptions more explicit in test_jvm_app to make sure errors
    of type TargetDefinintionExeption have an address specified
  • New custom PayloadField added for JarRules

Added unit tests. CI passed at: https://travis-ci.org/pantsbuild/pants/builds/56576452

Issues

  • 0
  • 9
  • 0
  • 9
Description From Last Updated
Eric Ayers
Eric Ayers
Eric Ayers
Patrick Lawson
Eric Ayers
Eric Ayers
Eric Ayers
Patrick Lawson
Eric Ayers
Eric Ayers
Patrick Lawson
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review Patrick. Commit 6273e07

Loading...