Place the workdir below the pants_workdir

Review Request #2007 - Created March 30, 2015 and submitted

Information
Stu Hood
pants
1604ed9...
Reviewers
pants-reviews
benjyw, jinfeng, jsirois

Locate the TaskTestBase workdir below the pants_workdir, which is automatically cleaned up.

This makes it easier to test Tasks that create synthetic targets, as it is common/best-practice to create synthetic targets within your workdir. Previously this would have failed indicating that the SourceRoot for the synthetic target was outside the BuildRoot.

We use the base classes provided by testinfra to test our internal Tasks, and encountered this while testing a codegen task.

https://github.com/pantsbuild/pants/pull/1346

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Benjy Weinberger
Eric Ayers
Stu Hood
Review request changed

Status: Closed (submitted)

Loading...